From b1187f5071f364162b9b024dcda2952e41a79007 Mon Sep 17 00:00:00 2001
From: Mathias Kresin <dev@kresin.me>
Date: Thu, 4 Aug 2016 22:38:28 +0200
Subject: [PATCH] use links instead of spans

This way the icons can be used even without javascript as all other
links.
---
 assets/css/app.css      |  6 +++---
 templates/item.php      | 10 ++++++----
 templates/show_item.php |  4 ++--
 3 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/assets/css/app.css b/assets/css/app.css
index 3b03b9c..6d39168 100644
--- a/assets/css/app.css
+++ b/assets/css/app.css
@@ -362,9 +362,9 @@ a.btn-red:hover,
 /* icons */
 article .read-icon,
 article .bookmark-icon {
-    cursor: pointer;
-    color: #aaa;
-    font-weight: 200;
+    color: #aaa !important;
+    font-weight: 200 !important;
+    text-decoration: none !important;
 }
 
 article[data-item-bookmark="0"] .bookmark-icon:before {
diff --git a/templates/item.php b/templates/item.php
index 6c06640..613673e 100644
--- a/templates/item.php
+++ b/templates/item.php
@@ -8,18 +8,20 @@
     >
     <h2 <?= Helper\is_rtl($item) ? 'dir="rtl"' : 'dir="ltr"' ?>>
         <span class="item-icons">
-            <span
+            <a
                 class="bookmark-icon"
+                href="?action=bookmark&amp;value=<?= (int)!$item['bookmark'] ?>&amp;id=<?= $item['id'] ?>&amp;offset=<?= $offset ?>&amp;menu=<?= $menu ?>&amp;feed_id=<?= $item['feed_id'] ?>"
                 title="<?= ($item['bookmark']) ? t('remove bookmark') : t('bookmark') ?>"
                 data-action="bookmark"
                 data-reverse-title="<?= ($item['bookmark']) ? t('bookmark') : t('remove bookmark') ?>"
-            ></span>
-            <span
+            ></a>
+            <a
                 class="read-icon"
+                href="?action=<?= ($item['status'] === 'unread') ? 'mark-item-read' : 'mark-item-unread' ?>&amp;id=<?= $item['id'] ?>&amp;offset=<?= $offset ?>&amp;redirect=<?= $menu ?>&amp;feed_id=<?= $item['feed_id'] ?>"
                 title="<?= ($item['status'] === 'unread') ? t('mark as read') : t('mark as unread') ?>"
                 data-action="<?= ($item['status'] === 'unread') ? 'mark-read' : 'mark-unread' ?>"
                 data-reverse-title="<?= ($item['status'] === 'unread') ? t('mark as unread') : t('mark as read') ?>"
-            ></span>
+            ></a>
         </span>
         <span class="item-title">
         <?= Helper\favicon($favicons, $item['feed_id']) ?>
diff --git a/templates/show_item.php b/templates/show_item.php
index 47c1f68..d5764ea 100644
--- a/templates/show_item.php
+++ b/templates/show_item.php
@@ -35,13 +35,13 @@
 
         <ul class="item-infos">
             <li>
-                <span
+                <a
                     class="bookmark-icon"
                     href="?action=bookmark&amp;value=<?= (int)!$item['bookmark'] ?>&amp;id=<?= $item['id'] ?>&amp;source=show&amp;menu=<?= $menu ?>"
                     title="<?= ($item['bookmark']) ? t('remove bookmark') : t('bookmark') ?>"
                     data-reverse-title="<?= ($item['bookmark']) ? t('bookmark') :t('remove bookmark') ?>"
                     data-action="bookmark"
-                ></span>
+                ></a>
             </li>
             <li>
                 <a href="?action=feed-items&amp;feed_id=<?= $feed['id'] ?>"><?= Helper\escape($feed['title']) ?></a>