I opted for a capital A (Shift + A) since it seems less likely that
a user would press that shortcut unintentionally compared to just 'a'
without any modifiers.
Added help and de_DE translation for new shortcut
Fixes#629: After using keyboard hotkey (j, k) to navigate to a story on the
unread list and opening the story with "v", the next unread item is now
selected so that the current position won't be lost and the user doesn't have
to start from the top of the list again.
The `/` character is entered into the search field after activating it via
the `keypress` event. That's unexpected behaviour.
This commit fixes that by attaching the keyboard event handler to the
`keyup` event.
search field in web apps, e. g. DuckDuckGo or Google Plus.
Some editors and pagers use the same shortcut (Vim, less, ...).
This commit adds an event handler for the pressed / key which
calls the `ShowSearch()` function.
The links were silently dropped with commit
4c0d975532 "Make clickable icons"
without any mention in the commit message.
Based on the commit title, I would assume this is an additional
functionality and not something that replaces existing stuff.
It's annoying to move the mouse across the screen (reading text from
the left to right) to get to the mark read icon for marking an article
as read.
All changes related to the removal of the links are reverted by keeping
the clickable icons.
Beside other stuff the main reason for this change is the circumstance
that Firefox triggers the "Toggle RTL mode" shortcut if the user press
F11 to switch Firefox into the fullscreen mode.
Each browser sends keycodes that are used by different other keys on
the keyboard for the function keys. Firefox is the only browser which
sends the onkeypress event for the function keys.
The used keyboard event properties event.keyCode and event.which are
already marked as deprecated and has been removed from the Web standards.
The "DOM Level 3 Events" standard specifies event.key as their successor.
Right now event.key is only available for Firefox 29+ and Internet
Explorer 9+. Webkit based browser have support for the former specified
event.keyIdentifier.
The implementation of event.keyIdentifier isn't the same across
different webkit based browsers and buggy:
- the value for the z key is F11 (Chrome - Windows, Linux)
- the value for the F11 key is F11 as well on (Chrome - Windows, Linux)
- the value for latin keys is always the value of the capital letter (Chrome)
- the value for cyrillic keys depends on the shift modifier (Chrome)
- the value for the keypress event is always an empty string (Safari - Mac OS)
- the value for the keydown event matches the keyboard layout dependent character (Safari - Mac OS)
- the value for the keydown event does NOT matches the keyboard layout dependent character (Chrome - Windows, Linux)
Instead of workaround the problems, the event.which is used for every
browser that doesn't support event.key.
The redirect to the unread page after a manual refresh only, if new
items could be fetched and we where redirected to the subscriptions
page because of a former nothing_to_read.
Update the unread counter after refreshing either one feed or all feeds.
Redirect to unread if nothing_to_read is set, but unread items exists.
This could be the situation with the remember me function, when new items
are fetched while the browser was closed.
Only the unread counter is updated right know.
The AutoUpdate Feature is designed on the premise of don't wasting resources. A
distinction is made between updates when Miniflux is visible or hidden.
To determine the visibility status, the Page Visibility API is used. The API is
available starting with Chrome 33, Firefox 18 and IE10. [https://developer.mozilla.org/en-US/docs/Web/Guide/User_experience/Using_the_Page_Visibility_API]
As IE9 returns an undefined, it doesn't break the compatibility at least.
If Miniflux is visible, the unread counter on the web page is updated as soon as
a mismatch between the counter and the number of unread articles in the database
is found.
If Miniflux is hidden, the timestamp of the most recent article from each feed
is compared with the value from the last run. We have an update If the timestamp
of the latest article is greater than the stored one and the latest article is
unread. The web page title is updated with a ? symbol to notify the user and the
update check pauses till Miniflux gets visible again. If Miniflux gets visible
again, the number of unread articles is queried from the database, the unread
counter on the web page is updated and finally the ? symbol is removed from the
web page title.
This way I can use my fever API client to read new articles (or at least the
latest article) while Miniflux is hidden and as I've seen the new articles
already a new articles notification is prevented.
It's intentionally that the page does not reload automatically as long as
articles are visible. If I'm in hurry, I only scroll through the articles to
spot something interesting. Most of the time I don't reach the last article.
If the page is reloaded while I'm away, I would have to scan from the top again.
If we're on a nothing_to_read page and have unread articles in the database, a
redirect to the unread page will be done.
The default update check interval is 10 minutes and can be changed on the
settings page. A zero value disables the update check entirely.
fixes#213
Major benefit, beside a smaller file size, is the possibility to remove debug informations from the minified javascript.
make-js script:
- take care of any warnings and errors
- raise warning level to verbose
js/*
- switch to Array-Access Property Notation for external data (prevents renaming by the closure compiler)
Show feeds with errors always at the top and highlight them
Changes the feed order to:
1. failed
2. enabled
3. disabled
Order alphabetical within each group.
Show a warning message with a hin to the console if feeds have issues
Fixes#300, #303
This is a follow up to #1. The onclick event is triggered by different
mouse buttons across browsers:
Firefox
- all mouse buttons trigger document.onclick (https://bugzilla.mozilla.org/show_bug.cgi?id=430310)
- only left mouse button triggers document.body.onclick
Internet Explorer
- only left mouse button and without any modifier key triggers
document.onclick
Chrome
- left & middle mouse button trigger document.onclick
Safari
- left mouse button triggers document.onclick
- middle click via mac os?
By switching to the onmouseup event this can be unified for all
mentioned browsers to:
- (CTRL+) left click triggers event
- middle click triggers event
- right click does nothing
The 'open original' link marks the item as read but doesn't open the
article.
After double clicking one 'open original' link, all other
'open original' links open the article as expected. Sounds like the IE
blocks the 'popup' silenty here.
The following in #196 reported issues are fixed by the change as well:
- a middle click on an 'open original' link triggers the popup blocker
- original link opened via middle click is always a foreground tab
I've dropped it accidentally with my last commit. Furthermore I moved
the data-feed-id definition to the article element and dropped multiple
references of the feed id. That's similar to what I've done before with
the data-item-id in 3dae99ac.
The article element holds the information whether a feed is disabled now.
Now it is shown if a feed had errors while updating.
Frederic Guillot
denfil
Alexander Steinhöfer
Marcus Jaschen
Mathias Kresin
Samuel Gyger
Denis Filimonov
Mathias Kresin
Kordian Bruck