Don't hide the active element, it annoying to use the navigation if the
menu items changing there position with every click. Indicate the active
menu item instead, similar to the header navigation.
May I've worked to long with windows systems, but help and about have to
be the last menu items :-). I've reorderd the menu items to what I think
user need more often.
A sub-navigation should not change its parent heading. Changed that as
well.
- enable debug logging for image proxy
- show enclosure image only if no article content exists
- do not store empty favicons
- fix typo in get_item_favicons (worked anyway since get_favicons
returned all known favicons instead)
This script replaces make-archive.sh and make-tag.sh.
Switch to 'git archive' to create a ZIP file from the repo. Its way
more faster, automates a lot things and works with the GitHub download
HEAD/Release/Tag as ZIP functionality as well.
git archive reads the file .gitattributes to determine which files has
to be excluded from the zip file.
It replaces the following placeholders in common.php:
$Format:%d$": with the output of git log --pretty=format:%d which
contains the tag of the last commit (if tagged).
$Format:%H$": with the hash of the latest included commit.
If no tag can be found the hash is appended to "master" and shown as
version number.
The approach is kind of hackish since no distinct format option for the
tag exists.
Fixes#231, https://github.com/fguillot/miniflux/issues/213#issuecomment-65631765
This is a follow up to #1. The onclick event is triggered by different
mouse buttons across browsers:
Firefox
- all mouse buttons trigger document.onclick (https://bugzilla.mozilla.org/show_bug.cgi?id=430310)
- only left mouse button triggers document.body.onclick
Internet Explorer
- only left mouse button and without any modifier key triggers
document.onclick
Chrome
- left & middle mouse button trigger document.onclick
Safari
- left mouse button triggers document.onclick
- middle click via mac os?
By switching to the onmouseup event this can be unified for all
mentioned browsers to:
- (CTRL+) left click triggers event
- middle click triggers event
- right click does nothing
The 'open original' link marks the item as read but doesn't open the
article.
After double clicking one 'open original' link, all other
'open original' links open the article as expected. Sounds like the IE
blocks the 'popup' silenty here.
The following in #196 reported issues are fixed by the change as well:
- a middle click on an 'open original' link triggers the popup blocker
- original link opened via middle click is always a foreground tab
This prevents UI glitches with RTL feeds.
Use the unicode LTR marker character to hint the rending engine which
part of a RTL/LTR mixed string is LTR. This prevents UI glitches with
RTL feeds like http://www.ynet.co.il/Integration/StoryRss544.xml.
The entity has to be outside of the span tag to prevent flickering when
the counter is update via javascript.
I've dropped it accidentally with my last commit. Furthermore I moved
the data-feed-id definition to the article element and dropped multiple
references of the feed id. That's similar to what I've done before with
the data-item-id in 3dae99ac.
The article element holds the information whether a feed is disabled now.
Now it is shown if a feed had errors while updating.
Utilize apaches mod_rewrite to append a database parameter to the fever
api script based on the requested URL. Basically everything after
/fever/ is treated as the desired database. E.g. using
https://www.miniflux.net/fever/custom.sqlite/ as server url selects this
database as sync source/target.
The user supplied database parameter is compared with the output of
Model\Database\get_all(), which ensures that only files within the
DATA_DIRECTORY can be referenced (prevents File Inclusion/Directory
Traversal vulnerabilities).
I've tested it against Reeder on iOS. Note that Reeder does not allow
the same user name to be used multiple times within the same domain
name, even if the used URLs are different.
Mathias Kresin
Frederic Guillot
Kordian Bruck
silvus
Kaminary
Tobi