Show feeds with errors always at the top and highlight them
Changes the feed order to:
1. failed
2. enabled
3. disabled
Order alphabetical within each group.
Show a warning message with a hin to the console if feeds have issues
Fixes#300, #303
Don't hide the active element, it annoying to use the navigation if the
menu items changing there position with every click. Indicate the active
menu item instead, similar to the header navigation.
May I've worked to long with windows systems, but help and about have to
be the last menu items :-). I've reorderd the menu items to what I think
user need more often.
A sub-navigation should not change its parent heading. Changed that as
well.
- enable debug logging for image proxy
- show enclosure image only if no article content exists
- do not store empty favicons
- fix typo in get_item_favicons (worked anyway since get_favicons
returned all known favicons instead)
This prevents UI glitches with RTL feeds.
Use the unicode LTR marker character to hint the rending engine which
part of a RTL/LTR mixed string is LTR. This prevents UI glitches with
RTL feeds like http://www.ynet.co.il/Integration/StoryRss544.xml.
The entity has to be outside of the span tag to prevent flickering when
the counter is update via javascript.
I've dropped it accidentally with my last commit. Furthermore I moved
the data-feed-id definition to the article element and dropped multiple
references of the feed id. That's similar to what I've done before with
the data-item-id in 3dae99ac.
The article element holds the information whether a feed is disabled now.
Now it is shown if a feed had errors while updating.
Use CSS3 Animation for the "loading icon" blinking and move the definition of
the loading icon to CSS as well.
CSS3 Animations are supported by IE10, Firefox and using the -webkit prefix by
Chrome and Safari.
I've dropped the usage of element.classList in favour of supporting refreshing/
article downloading in IE9 (again). The classList stuff isn't necessarily
needed, as the elements in question only get one or no class assigned.
I've dropped no longer supported css options like:
the appearance option isn't supported by any browser, the -webkit-appearance
doesn't change anything visible.
-webkit-font-smoothing support was dropped in chrome 22 and font-smoothing
isn't specified anywhere.
The item id exists as data attribute or as element.id postfix on multiple
elements in an article.
The basic idea is to traverse the DOM tree - starting from the event firing
element - in reverse order till an article element is found.
This article element is passed to the JavaScript functions. These JavaScript
functions are getting the elements which they want to manipulate starting from
the article utilizing the JavaScript querySelector function.
The bootstrap themes had a conflicting and unused class style definied, which is
removed by now.
Unified the page-counters before.
This makes processing of counters in javascript way more easier. The minimum
required browser versions for the needed CSS3 selectors are IE9, Firefox 3.5
and Chrome 5. Confirmed working with IE9, Firefox 24.6, Chrome 36, Mobile Safari
on iOS6.
An unintended side effect of CSS brackets is that theme designers are able to
implement there idea of brackets.
Remove line breaks and indentation around links text: At least Chrome/Firefox on
Windows add the white space(s) from the HTML Code to the link text, which
results in "jumping" labels. The behaviour can be observed with the Hello Theme
while toggling the bookmark status.
Inserts a (unread/total)" items count in front of each subcription
on the feeds page.
models/feed.php adds two functions: get_feed_unread_counts(), get_all_w_counts().
get_feed_unread_counts - returns either an array of (unread/total) counts indexed
by feed id or a singl (unread/total) for a specific id.
get_all_w_counts() returns the same as get_all() but appends items_unread and
items_total columns.
controller/feed.php modifies Router\post_action('refresh-feed',function() to
retrun the (unread/total) count in the retruned ajax json array.
Router\get_action('feeds',function() was modified to call get_all_w_counts().
templates/feeds.php was modified to insert the (unread/total) count into the
span id="loading-feed-" such that is can be updated after a refresh.
assets/js/feed.js was modified to to have the Update and hideRefreshIcon
update the returned (unread/total) amounts in the "loading-feed" span.
Essentially, if an enclosure tag exists in the item, then the item menu will contain
a link 'multimedia [speaker symbol]' to the media url. Otherwise, if there is no
enclosure tag, there is no menu item shown.
This feature required adding an enclosure column to the items table (models/schema.php)
and bumping the DB version to 21 (models/config.php). I also added enclosure tag logic
to the Rss20 parser, the model/item.php and template/item.php files.
