The links were silently dropped with commit
4c0d975532 "Make clickable icons"
without any mention in the commit message.
Based on the commit title, I would assume this is an additional
functionality and not something that replaces existing stuff.
It's annoying to move the mouse across the screen (reading text from
the left to right) to get to the mark read icon for marking an article
as read.
All changes related to the removal of the links are reverted by keeping
the clickable icons.
Articles without paragraphs should have a margin to item action as well. Fix this issue by adding the margin to the container element.
There must be no space between between the <div class="preview-full-content"> and the $item['content']. The CSS pseudo-class :empty does not consider a div with whitespaces only as empty. The Selectors Level 4 Draft[1] as of 13 September 2015, mentions the CSS pseudo-class :blank which will do so. But it's a draft and not yet implemented by the majority of the browsers.
[1] https://drafts.csswg.org/selectors-4/#the-blank-pseudo
there must be no space between between the <p class="preview"> and the $item['content']. The CSS pseudo-class :empty does not consider a paragraph with whitespaces as empty. The Selectors Level 4 Draft[1] as of 13 September 2015, mentions the CSS pseudo-class :blank which will do so. But it's a draft and not yet implemented by the majority of the browsers.
[1] https://drafts.csswg.org/selectors-4/#the-blank-pseudo
The item id exists as data attribute or as element.id postfix on multiple
elements in an article.
The basic idea is to traverse the DOM tree - starting from the event firing
element - in reverse order till an article element is found.
This article element is passed to the JavaScript functions. These JavaScript
functions are getting the elements which they want to manipulate starting from
the article utilizing the JavaScript querySelector function.
The bootstrap themes had a conflicting and unused class style definied, which is
removed by now.
Remove line breaks and indentation around links text: At least Chrome/Firefox on
Windows add the white space(s) from the HTML Code to the link text, which
results in "jumping" labels. The behaviour can be observed with the Hello Theme
while toggling the bookmark status.
Essentially, if an enclosure tag exists in the item, then the item menu will contain
a link 'multimedia [speaker symbol]' to the media url. Otherwise, if there is no
enclosure tag, there is no menu item shown.
This feature required adding an enclosure column to the items table (models/schema.php)
and bumping the DB version to 21 (models/config.php). I also added enclosure tag logic
to the Rss20 parser, the model/item.php and template/item.php files.