This is a follow up to #1. The onclick event is triggered by different
mouse buttons across browsers:
Firefox
- all mouse buttons trigger document.onclick (https://bugzilla.mozilla.org/show_bug.cgi?id=430310)
- only left mouse button triggers document.body.onclick
Internet Explorer
- only left mouse button and without any modifier key triggers
document.onclick
Chrome
- left & middle mouse button trigger document.onclick
Safari
- left mouse button triggers document.onclick
- middle click via mac os?
By switching to the onmouseup event this can be unified for all
mentioned browsers to:
- (CTRL+) left click triggers event
- middle click triggers event
- right click does nothing
The 'open original' link marks the item as read but doesn't open the
article.
After double clicking one 'open original' link, all other
'open original' links open the article as expected. Sounds like the IE
blocks the 'popup' silenty here.
The following in #196 reported issues are fixed by the change as well:
- a middle click on an 'open original' link triggers the popup blocker
- original link opened via middle click is always a foreground tab
This prevents UI glitches with RTL feeds.
Use the unicode LTR marker character to hint the rending engine which
part of a RTL/LTR mixed string is LTR. This prevents UI glitches with
RTL feeds like http://www.ynet.co.il/Integration/StoryRss544.xml.
The entity has to be outside of the span tag to prevent flickering when
the counter is update via javascript.
I've dropped it accidentally with my last commit. Furthermore I moved
the data-feed-id definition to the article element and dropped multiple
references of the feed id. That's similar to what I've done before with
the data-item-id in 3dae99ac.
The article element holds the information whether a feed is disabled now.
Now it is shown if a feed had errors while updating.
Utilize apaches mod_rewrite to append a database parameter to the fever
api script based on the requested URL. Basically everything after
/fever/ is treated as the desired database. E.g. using
https://www.miniflux.net/fever/custom.sqlite/ as server url selects this
database as sync source/target.
The user supplied database parameter is compared with the output of
Model\Database\get_all(), which ensures that only files within the
DATA_DIRECTORY can be referenced (prevents File Inclusion/Directory
Traversal vulnerabilities).
I've tested it against Reeder on iOS. Note that Reeder does not allow
the same user name to be used multiple times within the same domain
name, even if the used URLs are different.
Use CSS3 Animation for the "loading icon" blinking and move the definition of
the loading icon to CSS as well.
CSS3 Animations are supported by IE10, Firefox and using the -webkit prefix by
Chrome and Safari.
I've dropped the usage of element.classList in favour of supporting refreshing/
article downloading in IE9 (again). The classList stuff isn't necessarily
needed, as the elements in question only get one or no class assigned.
I've dropped no longer supported css options like:
the appearance option isn't supported by any browser, the -webkit-appearance
doesn't change anything visible.
-webkit-font-smoothing support was dropped in chrome 22 and font-smoothing
isn't specified anywhere.
