use links instead of spans

This way the icons can be used even without javascript as all other
links.
This commit is contained in:
Mathias Kresin 2016-08-04 22:38:28 +02:00
parent 48be7a1fff
commit b1187f5071
3 changed files with 11 additions and 9 deletions

View File

@ -362,9 +362,9 @@ a.btn-red:hover,
/* icons */ /* icons */
article .read-icon, article .read-icon,
article .bookmark-icon { article .bookmark-icon {
cursor: pointer; color: #aaa !important;
color: #aaa; font-weight: 200 !important;
font-weight: 200; text-decoration: none !important;
} }
article[data-item-bookmark="0"] .bookmark-icon:before { article[data-item-bookmark="0"] .bookmark-icon:before {

View File

@ -8,18 +8,20 @@
> >
<h2 <?= Helper\is_rtl($item) ? 'dir="rtl"' : 'dir="ltr"' ?>> <h2 <?= Helper\is_rtl($item) ? 'dir="rtl"' : 'dir="ltr"' ?>>
<span class="item-icons"> <span class="item-icons">
<span <a
class="bookmark-icon" class="bookmark-icon"
href="?action=bookmark&amp;value=<?= (int)!$item['bookmark'] ?>&amp;id=<?= $item['id'] ?>&amp;offset=<?= $offset ?>&amp;menu=<?= $menu ?>&amp;feed_id=<?= $item['feed_id'] ?>"
title="<?= ($item['bookmark']) ? t('remove bookmark') : t('bookmark') ?>" title="<?= ($item['bookmark']) ? t('remove bookmark') : t('bookmark') ?>"
data-action="bookmark" data-action="bookmark"
data-reverse-title="<?= ($item['bookmark']) ? t('bookmark') : t('remove bookmark') ?>" data-reverse-title="<?= ($item['bookmark']) ? t('bookmark') : t('remove bookmark') ?>"
></span> ></a>
<span <a
class="read-icon" class="read-icon"
href="?action=<?= ($item['status'] === 'unread') ? 'mark-item-read' : 'mark-item-unread' ?>&amp;id=<?= $item['id'] ?>&amp;offset=<?= $offset ?>&amp;redirect=<?= $menu ?>&amp;feed_id=<?= $item['feed_id'] ?>"
title="<?= ($item['status'] === 'unread') ? t('mark as read') : t('mark as unread') ?>" title="<?= ($item['status'] === 'unread') ? t('mark as read') : t('mark as unread') ?>"
data-action="<?= ($item['status'] === 'unread') ? 'mark-read' : 'mark-unread' ?>" data-action="<?= ($item['status'] === 'unread') ? 'mark-read' : 'mark-unread' ?>"
data-reverse-title="<?= ($item['status'] === 'unread') ? t('mark as unread') : t('mark as read') ?>" data-reverse-title="<?= ($item['status'] === 'unread') ? t('mark as unread') : t('mark as read') ?>"
></span> ></a>
</span> </span>
<span class="item-title"> <span class="item-title">
<?= Helper\favicon($favicons, $item['feed_id']) ?> <?= Helper\favicon($favicons, $item['feed_id']) ?>

View File

@ -35,13 +35,13 @@
<ul class="item-infos"> <ul class="item-infos">
<li> <li>
<span <a
class="bookmark-icon" class="bookmark-icon"
href="?action=bookmark&amp;value=<?= (int)!$item['bookmark'] ?>&amp;id=<?= $item['id'] ?>&amp;source=show&amp;menu=<?= $menu ?>" href="?action=bookmark&amp;value=<?= (int)!$item['bookmark'] ?>&amp;id=<?= $item['id'] ?>&amp;source=show&amp;menu=<?= $menu ?>"
title="<?= ($item['bookmark']) ? t('remove bookmark') : t('bookmark') ?>" title="<?= ($item['bookmark']) ? t('remove bookmark') : t('bookmark') ?>"
data-reverse-title="<?= ($item['bookmark']) ? t('bookmark') :t('remove bookmark') ?>" data-reverse-title="<?= ($item['bookmark']) ? t('bookmark') :t('remove bookmark') ?>"
data-action="bookmark" data-action="bookmark"
></span> ></a>
</li> </li>
<li> <li>
<a href="?action=feed-items&amp;feed_id=<?= $feed['id'] ?>"><?= Helper\escape($feed['title']) ?></a> <a href="?action=feed-items&amp;feed_id=<?= $feed['id'] ?>"><?= Helper\escape($feed['title']) ?></a>